[Done] Customizable default in filter composer

Various discussions related to Adblock Plus development
Locked
User avatar
Adblock Plus Fan
Posts: 1255
Joined: Sat Feb 24, 2007 11:08 am

[Done] Customizable default in filter composer

Post by Adblock Plus Fan »

Discussion started here:
http://adblockplus.org/forum/viewtopic. ... 2567#22567

http://adblockplus.org/images/73.png
Basically I want to be able to choose which of those 4 rows should be the default suggestion in the composer.

Can we have an about:config option for this?

I tried to give the default choice a chance ever since it was introduced in the dev. builds, but I never really got used to it. As posted in the other topic, I feel it's annoying to change to the 4th option every time.
theinvoker
Posts: 9
Joined: Sat Apr 26, 2008 10:26 pm

Post by theinvoker »

i agree
Ares2
Posts: 1275
Joined: Fri Feb 15, 2008 12:47 pm

Post by Ares2 »

+1
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

+2
smk
Posts: 100
Joined: Mon Jul 14, 2008 6:54 am

Re:

Post by smk »

+3
Ares2
Posts: 1275
Joined: Fri Feb 15, 2008 12:47 pm

Post by Ares2 »

Hmm, maybe you should think about the default option again. While it may be the best one if you're trying to block ads, most people use a subscription for that anyway and use ABP to block other images. Then this option is really bad (see http://adblockplus.org/forum/viewtopic.php?t=3243 ).

While some people complaining about ads "coming back" are really bearable (as you can tell them they should choose a different option in the filter composer, or they even see it themselves after blocking some similar ads), having many people who are writing too general rules is definitely worse IMO.
Wladimir Palant
ABP Developer
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany
Contact:

Post by Wladimir Palant »

"Me too" comments really aren't helping...

@Ares2: I don't think that the default should be changed - of course we get relatively many complains after a release, but so far nobody complained about having blocked too much. So far we only had experienced users complaining about having to break their habits.
Wladimir Palant
ABP Developer
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany
Contact:

Post by Wladimir Palant »

Done: http://hg.mozdev.org/adblockplus/rev/50f1e025fc37

This added a hidden preference extensions.adblockplus.composer_default. Default value is 2. 0 means "Custom", 1 means "Full URL without query", 3 means "Host name only".
meo1960

I've tried adding the extensions.adblockplus.composer_defaul

Post by meo1960 »

and changed it to all possible values with no change in the default option on the adblock plus screen


It wasn't stated but I assumed the value to add to the about:config screen was an INTEGER VALUE, is this correct?

Also, the link citing the code isn't clear to me why that is there. Am I supposed to add this code into firefox somehow? If so, I really havent a clue how to do that.

Any Help would be appreciated. I have FF version 3.05 and adblock plus version 1.0
MonztA
ABP IT Officer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Post by MonztA »

You need the latest development build.
Locked