Collapse blocked element: bug?

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey
Post Reply
eccentra

Collapse blocked element: bug?

Post by eccentra »

To reproduce this behaviour:

Browse to https://webmail.blueyonder.co.uk.
Block https://webmail.blueyonder.co.uk/src/top.html

Post-1.0, there's a large blank area at the top of the page where the ads used to be.
Pre-1.0, this blank area disappeared, leaving more room for the rest of the page.

Is this a new bug? Is there a workaround?

Thanks,

Matt
Simon

Post by Simon »

I have the same problem with a frame on a different website and I can't solve it, even not with the about:config site...

Seems to be a bug.

Simon
Wladimir Palant
ABP Developer
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany
Contact:

Post by Wladimir Palant »

Yes, that site defines frames in an unusual way. I improved frame handling to consider this: http://hg.mozdev.org/adblockplus/rev/78dd78a811f5
eccentra

Thanks!

Post by eccentra »

That was quick! Thank you very much...
Simon

Post by Simon »

Sry for my stupid question but how can I paste it to my adblock?
Or do the changes come in the next Adblock update?

Simon
Wladimir Palant
ABP Developer
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany
Contact:

Post by Wladimir Palant »

Yes, please wait for the next development build/release.
vjanakir
Posts: 2
Joined: Tue Dec 16, 2008 1:13 am

Post by vjanakir »

The blocked frame in the top of this web page
is not collapsed. Is it the same as mentioned
in this thread?

http://www.morningstar.com/Cover/Stocks.html

Thanks.
Ares2
Posts: 1275
Joined: Fri Feb 15, 2008 12:47 pm

Post by Ares2 »

There is no blocked frame, it's a div-element that contains the ad. These are usually not removed automatically when the ad inside is blocked, but you can do it with an element hiding rule:

Code: Select all

morningstar.com#div(class=LeaderWrap)
If you use EasyElement, I'm sure this will be added soon.
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

Ares2 wrote: If you use EasyElement, I'm sure this will be added soon.
Done :arrow: :arrow: :arrow:
vjanakir
Posts: 2
Joined: Tue Dec 16, 2008 1:13 am

Post by vjanakir »

Ares2,

Added "morningstar.com#div(class=LeaderWrap)" to rules.

The blocked ad space got collapsed.

Thanks.
Post Reply