Latest Adblock Plus is broken in SeaMonkey 1.1

BenoitRen · Post by **BenoitRen** » Thu Jan 25, 2007 4:01 pm

I can't add any filters.

When I open the Adblock Preferences, and three times when I open a web page:
Error: wnd has no properties
Source File: chrome://adblockplus/content/data.js
Line: 213

When I press Enter to add the filter I inputted:
Error: this.data has no properties
Source File: chrome://adblockplus/content/settings.js
Line: 2045

I'm using one of the last SeaMonkey 1.1 Release Candidates, but since the browser component was already stable at that time, I think it happens in the official release as well.

BenoitRen · Post by **BenoitRen** » Thu Jan 25, 2007 4:01 pm

Oh yeah, the previous version (0.7.2.3) works fine.

Wladimir Palant · Post by **Wladimir Palant** » Thu Jan 25, 2007 4:53 pm

It doesn't work for me either. Chewey, does it work for you or why didn't you tell me?

Symptoms clearly show that XPCNativeWrappers are not enabled - but registration record in chrome.rdf says otherwise. If this is a SeaMonkey bug then a major one, and it is hard to believe that they wouldn't catch it before the release. Weird, I have to look into this.

Edit: It seems that it is only broken when you install it and have the profile manager pop up when you restart. When you restart SeaMonkey the second time it works again.

chewey · Post by **chewey** » Thu Jan 25, 2007 5:54 pm

Wladimir Palant wrote:It doesn't work for me either. Chewey, does it work for you or why didn't you tell me?

Well, sorry, I would've told you of course - but it indeed works for me. I have a
link on the desktop to directly start SM with my main profile, so I probably never
started SM's profile manager directly after an ABP installation. I'll add this to
the "things to test for" in the future.

Wladimir Palant · Post by **Wladimir Palant** » Thu Jan 25, 2007 8:10 pm

From what I can tell this is really a bug in SeaMonkey. I tried removing some problematic code parts from ABP and it didn't change anything - this issue doesn't seem to be triggered by anything we do. When SeaMonkey registers a new extension it doesn't enable XPCNativeWrappers. Only when SeaMonkey is restarted and reads the extension's registration from chrome.rdf it respects the setting. Working on a testcase...

Edit: I think I found the bug - and a work-around for it.
Edit2: Ok, "work-around" was a little too optimistic - cannot access this object from JavaScript.
Edit3: bug 368223

Wladimir Palant · Post by **Wladimir Palant** » Tue Jan 30, 2007 2:29 pm

The bug has been fixed, SeaMonkey 1.0.8 and 1.1.1 (once they are out) should no longer experience this problem.