[Fixed] Not a valid address error on latest nightly builds

[nitrox]

When I add a new filter subscription or update existing filter subscription I get Failed, Not a valid address. The list isn't downloaded.

I tried to narrow down the issue and I was able to reproduce this issue starting with 31-Mar-2012 17:20 hourly build.
I can reproduce this issue on 01-Apr-2012 04:40 build, as of posting this is the latest hourly build.

This issue can also be reproduced on latest trunk build ( 31-Mar-2012 20:02 )

There are no errors listed in Error console or on Adblock Plus error page ( chrome://adblockplus/content/errors.html )

Adblock Plus verson 2.0.4a.3420

Screenshot http://img853.imageshack.us/img853/8964 ... 124620.png

As you can see from screenshot, this issue occurs on subscriptions downloaded via http or https. Fanboy list and easy list are downloaded over HTTPS where as Xfiles is downloaded over HTTP. I subscribed these lists from add filter subscriptions menu in adblock plus preferences so the url should be correct.

Steps to reproduce,
1. Get any hourly build starting from 31-Mar-2012 17:20
2. Use existing profile or create a new profile
3. Try to update if it is a existing profile or just open adblock plus prefrences after installing ABP on new profile.

Note: For best results, with existing profile you need to have more than 1 subscription. When you force update all subscriptions, one might update but others will fail with Failed, not a valid address error.

[Hubird]

Confirmed with latest Nightly and Dev build of ABP.

[AA]

I noticed that I could only update the top one of subscriptions.
If I want to update another subscription I need move to the top then restart browser and click update.
Weird problem.

(And thanks, rob64rock)

[Wladimir Palant]

Yes, I noticed as well - constructing XMLHttpRequest is broken in the current nightly. Thank you for narrowing things down. I suspect bug 740069 but will need to check further (unfortunately, a batch of 69 patches landed in that hourly).

For reference: the regression range.

[Wladimir Palant]

I filed bug 741367 on this. I also created a work-around, will push it later along with a large batch of changes.

[nitrox]

the workaround doesn't seem to fix the bug. It still occurs on latest nightly + latest Dev ABP build.

Btw, I noticed the workaround is committed into EHH instead of ABP.

Code: Select all

Stopped using nsIJSXMLHttpRequest interface, replaced by nsIXMLHttpRequest

devbuilds/elemhidehelper/00latest.changelog.xhtml

Where as no commit in ABP since 26-03-2012
devbuilds/adblockplus/00latest.changelog.xhtml

The issue is with ABP so I don't understand why the workaround is done to EHH.

[Wladimir Palant]

will push it later along with a large batch of changes.

This push didn't happen yet.

[Anon]

will push it later along with a large batch of changes.

This push didn't happen yet.

Excuse me, will you release builds before weekend?

[nitrox]

In the commit comment you mentioned changing from one type of XMLHttpRequest to another and the bug was with creating second XMLHttpRequest, I assumed you rolled out the fix. My bad.

[Wladimir Palant]

This is fixed in the current development build: https://hg.adblockplus.org/adblockplus/rev/e169df4f5bce