[RESOLVED] Chrome Store broken with valid annoynce filter

Posting here is no longer possible, please use the corresponding product forum.
Locked
User avatar
vinny86
Posts: 735
Joined: Thu Sep 16, 2010 6:17 pm

[RESOLVED] Chrome Store broken with valid annoynce filter

Post by vinny86 »

chrome stable
ABP from chrome store
add annoyance sub from fanboy
click on any of the extensions/app in chrome store
doesn't display properly

this is the culprit filter

Code: Select all

http://google.com/js/plusone.js$third-party
any amount of manipulation to this filter also doesn't get the chrome store working

IMPORTANT: whitelisting through ABP icon or adding a filter whitelist also doesn't get the store to work.
turning off the entire annoyance list is the only way to make it work

EDIT : Problem occurs only after the upgrade from v16 to v17
User avatar
fanboy
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am
Contact:

Re: [URGENT ? :)] chrome store broken with valid annoynce filter

Post by fanboy »

Since adblock plus for chrome is having issues with 3rd party, I'll temporarly disable the filter till its fixed.. The filter shouldn't be affecting the chrome store since its 3rd party, but it is. :(

http://hg.fanboy.co.nz/rev/c8a51719d614
Noggie
Posts: 82
Joined: Tue Mar 29, 2011 12:46 pm

Re: [URGENT ? :)] chrome store broken with valid annoynce filter

Post by Noggie »

My issue is related or the same.
Filters:
× Recommended filters for Google Chrome
× Antisocial English
× Enabled Adversity Privacy
× Enabled EasyPrivacy+EasyList

I have added "chrome.google.com" to the whitelisted domains but it still doesn't work.
When disabling adblock extension it works.
When disabling filter "Antisocial English" it works.

adblock is active on sites that are whitelisted !!
Major bug i think, no ?
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

Re: [URGENT ? :)] chrome store broken with valid annoynce filter

Post by Hubird »

Slightly off topic:

You are using EasyList and EasyPrivacy so you should not use another privacy list (you should not use overlapping subscriptions).
Also I do not offer the privacy list as an individual list any more (it has been merged in to my main list).
Noggie
Posts: 82
Joined: Tue Mar 29, 2011 12:46 pm

Re: [URGENT ? :)] chrome store broken with valid annoynce filter

Post by Noggie »

Hubird wrote:Slightly off topic:

You are using EasyList and EasyPrivacy so you should not use another privacy list (you should not use overlapping subscriptions).
Also I do not offer the privacy list as an individual list any more (it has been merged in to my main list).
Yes i have heard that before. The problem is both subscriptions do not cover the same things.
Example:
sub 1: covers 1, 2 and 3
sub 2: covers 1, 4, and 5
Common overlap is 1.

Just choosing one over the other isn't perfect because no matter which one i choose i will lose functionality.
Yes there are probably some overlap but so far I've not noticed any problem with that and the functionality given outweighs the negative. at least for now.
Wladimir Palant

Re: [URGENT ? :)] chrome store broken with valid annoynce filter

Post by Wladimir Palant »

fanboy wrote:Since adblock plus for chrome is having issues with 3rd party
Shouldn't have... As of Adblock Plus 1.2 the third-party handling should work correctly.
User avatar
vinny86
Posts: 735
Joined: Thu Sep 16, 2010 6:17 pm

Re: Chrome Store broken with valid annoynce filter

Post by vinny86 »

but unfortunately it does Wladimir and the nature of the problem is very specific
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: Chrome Store broken with valid annoynce filter

Post by MonztA »

Latest dev build and Chrome 18 still has this issue for me. :?
Sc00by22

Re: Chrome Store broken with valid annoynce filter

Post by Sc00by22 »

Same thing for me MonztA :(
Wladimir Palant

Re: Chrome Store broken with valid annoynce filter

Post by Wladimir Palant »

Turned out that the issue is Chrome "protecting" chrome.google.com - it won't send these requests to us so that we don't know the context of the other requests we receive. Result being that we treat all of them as third party. This probably should be filed as a Chrome bug given that it violates assumptions made by the official documentation. I would like to work around it somehow but I don't see any options right now...

I guess that they need to be consistent and prevent extensions from intercepting any requests made by chrome.google.com, even when going to other sites. Otherwise an extension could still XSS the site and do all kinds of evil things.
Wladimir Palant

Re: Chrome Store broken with valid annoynce filter

Post by Wladimir Palant »

For reference: this is https://code.google.com/p/chromium/issu ... ?id=134101 now (currently hidden from public view).

I looked into this some more and I still cannot see any work-around that we could apply on our end. It's really up to the Chrome devs to fix this, marking as CantFix.
User avatar
vinny86
Posts: 735
Joined: Thu Sep 16, 2010 6:17 pm

Re: [CantFix] Chrome Store broken with valid annoynce filter

Post by vinny86 »

@ Wladimir : Has the bug been fixed ? :) I am unable to view the bug report (its still non public)

http://forums.fanboy.co.nz/forums/viewt ... 698#p35698
Wladimir Palant

Re: [CantFix] Chrome Store broken with valid annoynce filter

Post by Wladimir Palant »

Yes, a fix landed recently. If I understand their branch system correctly, it should be fixed starting with Chrome 21.0.1180.34 - that's the dev channel, beta and stable are still affected.
Locked