Very weird: in 2.0b1, AP makes 2 Help menu items disappear

Jheriko · Post by **Jheriko** » Thu Jul 13, 2006 6:40 am

"Report Broken Web Site" and the new "Report Phishing Website" item
both of which are in the Help menu.

Why the heck would Adblock Plus make them disappear though???

Makes no sense to me.

IceDogg · Post by **IceDogg** » Thu Jul 13, 2006 8:33 am

It's working ok for me. Maybe a filter? Not sure I filter can block that stuff, but I would disabled them all just to see.

Edit: typo fixed

Jheriko · Post by **Jheriko** » Fri Jul 14, 2006 12:02 am

I don't think a filter can POSSIBLY block a MENUBAR item.

That would like Adblock Plus being able to block the Reload or Stop button.

IceDogg · Post by **IceDogg** » Fri Jul 14, 2006 12:11 am

Well I know you can remove elements of Firefox with css stuff using things like userchrome.css or stylist. And since Adblock plus can also block elements I just assumed it MIGHT be possible. But I'm not sure either. Some of the others may know. But I still think it was worth a try just to see.

As I said though, it's working fine for me. So, it has to be something in your setup.

More info is needed however. What OS are you using? What version of Firefox? so on.

Jheriko · Post by **Jheriko** » Fri Jul 14, 2006 7:34 am

"More info is needed however. What OS are you using? What version of Firefox? so on."

2.0b1 (beta 1) on XP SP2

I tried this in a NEW profile, meaning it has NO other extensions or themes.

In about:config, I created and set the boolean "extensions.checkCompatibility" to "false"
in order to be able to install Adblock Plus,
which is currently for versions up till 2.0a3 (alpha 3) only.

I install AP, the 2 items disappear.

I disable it and restart, the 2 items reappear.

So logically, I assume that AP is the direct cause of this phenomenon.

EDIT:
To ensure that it's not ANY extension that makes this happen, I disabled AP, and randomly installed another extension (dragdropupload).

And now the 2 items are there, with AP being disabled and dragdropupload being enabled.

EDIT:
What the heck??
Okay, this is extremely bizarre. I enabled AP now, so that there are currently 2 extensions enabled: AP and dragdropupload.

Now the 2 items are there.

HOWEVER, the weird part:
I disabled dragdropupload, meaning now only AP is enabled.

The 2 items have disappeared again. o_O

It's like the items disappear ONLY when AP is the ONLY extension enabled.

EDIT:
Yet another situation:

I uninstall AP.
dragdropupload is disabled.
The 2 items are back.

I enable dragdropupload, meaning there is ONLY dragdropupload installed and enabled.
The 2 items are still there.

Is this more evidence that it IS Adblock Plus that is the cause of this?

IceDogg · Post by **IceDogg** » Fri Jul 14, 2006 7:50 am

Ok, sounds like you are on the trail of an odd ball bug. Tomorrow, when I got more time I'll see if I can reproduce with the steps you mentioned. I'll post back if I can.

Edit: Ok, I can reproduce this now. Just install adblock plus by itself and it will remove those menu items. Add another extension (sometimes) they will come back. Add a third extension and they come back. Some kind of bug here for sure. Also I couldn't get any other extensions to do this but I only tested 2 others.

rch · Post by **rch** » Sat Jul 15, 2006 11:25 pm

I have about 5 extensions installed and do not experience this bug.

Master X · Post by **Master X** » Sat Jul 15, 2006 11:37 pm

IceDogg wrote:Well I know you can remove elements of Firefox with css stuff using things like userchrome.css or stylist. And since Adblock plus can also block elements I just assumed it MIGHT be possible. But I'm not sure either. Some of the others may know.

Yes, it is possible. Adblock Plus can hide items, which belong to the browsers UI.

IceDogg · Post by **IceDogg** » Sat Jul 15, 2006 11:40 pm

Thanks Master X, I thought it would. But I played around with it and couldn't figure out how to prove it.

Master X · Post by **Master X** » Sat Jul 15, 2006 11:49 pm

Adblock Plus documentation says that this should work (e.g.):

Code: Select all

browser,navigator#menuitem(key=abp-key-settings)

http://adblockplus.org/en/faq_customization#menu_remove

IceDogg · Post by **IceDogg** » Sun Jul 16, 2006 12:56 am

thanks again!

Wladimir Palant · Post by **Wladimir Palant** » Mon Jul 17, 2006 3:24 pm

Unspecific element hiding filters shouldn't block anything in the UI, you have to specify a "domain" for this. As to the bug - it should be reported in bugzilla.mozilla.org (unless already there), this is unlikely an Adblock Plus bug.