Bug: right-clicking the Enabled 'green/grey ball' affects it

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey
Post Reply
Jheriko
Posts: 5
Joined: Fri Jun 30, 2006 11:44 am

Bug: right-clicking the Enabled 'green/grey ball' affects it

Post by Jheriko »

It should not affect it (that is, enable/disable), as a left click would.

It should only bring up the context menu. (well, in my opinion, anyway)



As yes, speaking of context menu, perhaps adding "Enable"/"Disable" to it would be nice.

Seeing as some people might not know off-hand what that "weird green little ball" is,
or more importantly, they don't know it's actually clickable.

Or they might have the whole Enabled column disabled.
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

Jheriko wrote:bump
You probably won't get an answer until next week as Wladimir probably won't be available until then :sad:
adum
Posts: 131
Joined: Fri Jun 09, 2006 7:39 pm

Post by adum »

We will have to wait for him (it is not urgen, anyway) but I think Jheriko is right: right click should only open context menu, in fact this is the standard behaviour if the mouse is hovered on any other column of this window.

Maybe the issue of enable/disable is something worth to be discussed; for me a green bullet is OK (short and evident) but there are many people using ABP who dont know there is such an option. It seems that 99 % of users do not read FAQ or help when installing the extension.
Wladimir Palant

Re: Bug: right-clicking the Enabled 'green/grey ball' affect

Post by Wladimir Palant »

Jheriko wrote:It should not affect it (that is, enable/disable), as a left click would.
Could I get more details? What do you see and on which OS/Firefox version?
Jheriko wrote:It should only bring up the context menu.
It does - IMO.
Jheriko wrote:As yes, speaking of context menu, perhaps adding "Enable"/"Disable" to it would be nice.
Isn't it already there?
adum
Posts: 131
Joined: Fri Jun 09, 2006 7:39 pm

Re: Bug: right-clicking the Enabled 'green/grey ball' affect

Post by adum »

In the Preferences window (at least using Fx 1.5.0.4 and Windows XP SP2, I do not have Linux available here) if you right click on a filter the context menu is displayed (but not enable/disable option on it) - unless the mouse is placed over the green bullet when you right click. In this last case instead of context menu, the filter (and the green bullet) changes from enabled to disabled, or the other way round.
It happens at least in the last ABP release, I did not notice it before Jheriko did so I do not know if it has been always there or not.
Wladimir Palant

Post by Wladimir Palant »

Ah, now I get it. Too late for 0.7.1.1 release sadly - it is in AMO's review queue already.

Edit: Fixed this.

Edit2: I thought better about it and replaced 0.7.1.1 in AMO's queue by a new build, so this bug will be fixed in the release.
Post Reply