ABP 0.7 inactive 'OK' button bug?

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey
Post Reply
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

ABP 0.7 inactive 'OK' button bug?

Post by rick752 »

I have received questions from 4 separate (reliable) people about the following possible bug:

They tell me if they right-click and edit a filter in the filter list window, the OK button will not highlight (stays grayed-out). If they DO close the filter list window when they're done, it WILL usually retain the change. These are ABP 0.7 installations that are clean of previous version remains.

However, this bug does not happen on my machine, though, so I CANNOT verify this or advise them ... everything works fine here.

Has anyone else seen/heard this?
User avatar
Lanik
Posts: 11
Joined: Sat Jun 10, 2006 5:12 am
Location: SF Bay Area

Post by Lanik »

WFM I don't get the problem mine seems to work just fine.
Fox
Posts: 300
Joined: Sat Jun 10, 2006 3:05 pm
Location: Finland

Re: ABP 0.7 inactive 'OK' button bug?

Post by Fox »

rick752 wrote:They tell me if they right-click and edit a filter in the filter list window, the OK button will not highlight (stays grayed-out).
Ask if they click elsewhere after editing.
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Re: ABP 0.7 inactive 'OK' button bug?

Post by rick752 »

Fox wrote: Ask if they click elsewhere after editing.
@Fox:

I think that this is what is they are not doing. From further discussion on the dslreports forum, it seems that the complaint comes from editing MULTIPLE filters where they are moving from one to another without clicking OFF the previous one. I'm under the impression that thaey would like to see an 'OK' after a single edit so they can continue again ... do you know what I mean? I think that is just the way 0.7 works.

Read the thread here ... one member showed the complaint with a series of screenshots down the thread:
http://www.dslreports.com/forum/remark, ... rt=100#end
Fox
Posts: 300
Joined: Sat Jun 10, 2006 3:05 pm
Location: Finland

Re: ABP 0.7 inactive 'OK' button bug?

Post by Fox »

rick752 wrote:From further discussion on the dslreports forum, it seems that the complaint comes from editing MULTIPLE filters where they are moving from one to another without clicking OFF the previous one. I'm under the impression that thaey would like to see an 'OK' after a single edit so they can continue again ... do you know what I mean?
Nope, i did not understand, but no need to clarify it.
ps: I did look dslreports forum topic, and from image 1, i see that he/she did not click elsewhere. But i did not understand something that he/she said. my english sucks:)
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

I think they feel that the 'OK' should work as soon as edit mode is selected.

So I would say that it is not a bug ... it's just the way the interface works. I can get 'OK' if I hit the ENTER key after editing a filter ... or click somewhere else in the filter box.
Wladimir Palant

Post by Wladimir Palant »

Hm, that makes sense - OK should become available as soon as you change something in the editor, even if you didn't confirm the change yet. Do you see any drawbacks?
Guest

Post by Guest »

Wladimir Palant wrote:Hm, that makes sense - OK should become available as soon as you change something in the editor, even if you didn't confirm the change yet. Do you see any drawbacks?
Wladimir .... it turns out that this problem is NOT with the functionality of ADP, but was a bug on only 2 peoples' machines on the DSL Reports forum. Anything that they did in the filter box would not highlight the OK button ... but if they made a change and hit CANCEL, the changes were saved (bug). I think it may have been a conflict with another extension that they both were using. They are both using ADP 0.7 now and I'm not hearing anything since last month about it.
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

LOGIN:

MY POST ABOVE :roll:
Wladimir Palant

Post by Wladimir Palant »

Ok, but the point still stands :)
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

@Wladimir:

I really have no opinion about this because I'm really not seeing the same problem that was first submitted to me. It seems that the only time that my OK does NOT highlight is when I am actually editing a filter string as a first command after opening the filter box ... but as soon as I close the edit box (after clicking anything else), the OK button highlights.

Seems like any other initiation in the filter box automatically highlights my OK button too. So I really don't know what to say here. :?

When do you think it should highlight .... as soon as you open the box?
Post Reply