[Done] Indication if subscription contains disabled filters

Various discussions related to Adblock Plus development
Locked
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

[Done] Indication if subscription contains disabled filters

Post by Hubird »

In the following thread

forum/viewtopic.php?f=4&t=2654

I put forward an idea to Indicate that some filters in a subscription are disabled, you liked the idea but said efficient implementation would be problematic.

I was just wondering if this was going to happen, problematic isn't impossible and I still feel it would be useful.
Wladimir Palant

Re: Indication if subscription contains disabled filters

Post by Wladimir Palant »

Ok, let's discuss this again - moved to future development forum.

This suggestion would mean that the preferences window needs to keep the count of disabled filters for each subscription (recalculating it every time it is needed is certainly not an option). This count needs to be updated when filters are disabled/enabled, moved or deleted, when subscriptions are updated, probably in more situations. Making sure that it is correct under all circumstances sounds like a tricky affair, will certainly add some complexity to the already overly complicated code.

Conclusion: At the moment I cannot see the big gain that would justify this. But I will be happy to learn otherwise.
User avatar
Erunno
Posts: 95
Joined: Sun May 03, 2009 11:09 am

Re: Indication if subscription contains disabled filters

Post by Erunno »

I guess it's mostly useful for subscription list maintainers and less so for ordinary users who subscribe to a list and leave it at that. I frequently have to disable certain filters either to test out new ones or in order to fix bugs and sometimes I forget to deactivate them after I have finished whatever prompted me to disable a filter in the first place. A visual cue in the subscription list window would surely help with the obsessive-compulsive disorder to check the filter lists regularly for inactive filters, especially when one is not using the activation sorting order and collapses the lists by default. It would just be a convenience but if the implementation costs are really that high I can live without (as I have until now).
EasyList Author (Apprentice level) - http://easylist.adblockplus.org/
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

Re: Indication if subscription contains disabled filters

Post by Hubird »

Wouldn't it be enough to just update the the count when the preference windows was first opened and when the apply button was pressed ?
Wladimir Palant

Re: Indication if subscription contains disabled filters

Post by Wladimir Palant »

No, users will complain then that this indicator is "stuck". Anyway, I want to consider this proposal again when redesigning preferences dialog for Adblock Plus 1.4.
Wladimir Palant

Re: [Done] Indication if subscription contains disabled filters

Post by Wladimir Palant »

I forgot to update this thread. This feature was implemented in Adblock Plus 2.0.
Locked