DIV with id and class, ABP omits class ... bad idea

Posting here is no longer possible, please use the forum of a filter list project, such as EasyList
Locked
Mugros

DIV with id and class, ABP omits class ... bad idea

Post by Mugros »

I am working on the page http://arstechnica.com/news.ars/post/20051224-5837.html

In the adblock list there are two obvious DIVs to be blocked, SkyScraperAd and _ctl4_NewsListing__ctl0_NewsPanelAd.
But there seems to be a problem how ABP names these DIVs. SkyScraperAd is a class, but _ctl4_NewsListing__ctl0_NewsPanelAd is an id. The second DIV is also of the class PanelAd, but if i make a filter for PanelAd the DIV won't be blocked.
There is also a div with id ContentBanner and class BannerAd. This shows as ContentBanner and not as BannerAd. A filter for BannerAd wouldn't catch it. And it is obviously wrong to have a general filter for ContentBanner, but BannerAd is a nice target.

It looks like ABP prefers the id and doesn't care about the class if an id is present.
This is not very good for adblocking. I would like to have a filter like (skyscraper|banner|panel)ad that works on this and every other website, but because of the ids this won't work.
Paulfox

Post by Paulfox »

Hi Mugros. I see NO ADS whatsoever, and I don't block DIV elements. The 3 filters of mine that show up as "effective" on that page are: (third one broken up so as not to widen the forum page; it should be spelled out as one line when you enter them in AdBlock) . . . . I have a feeling your "banner" reference is answered in the third filter (that's from FiltersetG, I believe)

/(207|bns1|chitika|cjt1|cpaffiliates|falkag|lduhtrp|mediaonenetwork|netshelter|onesweb|pro\-market|qksrv|st\.sageanalyst|sublimemedia|ultimateinsult|yceml)\.net/

/pagead\d\.google/

/[^a-z]banners?[/._-]?(.*(\d+x\d+\.swf|\.f?pl|redir|siteid=)|\.(cgi|js|php)|ad|affiliate|central|click|connect|count|current|exchange|file|grocery|id|
man(age(ment|r)|ia)|newsletter|/_?promo|/rotat|/?script|serve|skyscraper|space\.|swap|trust)/
Mugros

Post by Mugros »

The ad images are not the problem. I am not using filter sets but i have entries for the ad companies that provide the ad images for this site.
What i am talking about is the blocking of the DIVs on this page. I see blank spaces where the ad images were but i also want the DIVs to disappear. DIV blocking removes the blank DIVs, but ABP can't match the DIVs correctly because it discards the class-attribute and only looks at the id.
Itsnotvalid

Post by Itsnotvalid »

Ya I also want to get a way to disable those DIVs without a id name nor a class name.
Mugros

Post by Mugros »

DIVs without class or id can't be removed with adblock. But, in my case, i am talking about a DIV that has both. A class that can clearly be connected to ads and a unique id. Filtering for the class would be perfect but the id screws it all. This is clearly an design error within ABP.

If you really would like to filter unnamed DIVs you can use the "remove it permantly" extension. There you can specify for each site which elements you want to be removed. But this doesn't blocks the content in the DIV to be downloaded (, but AFAICS this is also the case in ABP).
Locked