Extremely severe slowdown in http://asa.org.il/

Posting here is no longer possible, please use the forum of a filter list project, such as EasyList
Locked
Safwat
Posts: 3
Joined: Sat Oct 17, 2015 9:20 pm

Extremely severe slowdown in http://asa.org.il/

Post by Safwat »

When visiting http://asa.org.il/ with Adblock Plus, the filtering counter skyrockets into millions, Adblock Plus "blocks" millions of stuff per second. CPU and hard drive IO are utilized maximally, and the entire system slows down. One of the tests even managed to crash Firefox. Closing http://asa.org.il/ instantly re-stablizes the system.

Tested in Chrome and Firefox.
Versions:
```
OS: Debian Jessie
Firefox: 38.3.0 (Iceweasel Branding), with Adblock Plus V2.6.11
Chromium: Version 45.0.2454.85 Built on 8.1, running on Debian 8.2 (64-bit), with Adblock Plus V1.9.3
```

Cross posted on github: https://github.com/adblockplus/adblockplus/issues/1
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: Extremely severe slowdown in http://asa.org.il/

Post by mapx »

what filter lists are enabled ?
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: Extremely severe slowdown in http://asa.org.il/

Post by mapx »

ok, it's a rule in easyprivacy, so add this filter:

Code: Select all

@@||eplayerhtml5.performgroup.com/js/tsEplayerHtml5/js/Eplayer/js/quantcast/$domain=eplayerhtml5.performgroup.com
Safwat
Posts: 3
Joined: Sat Oct 17, 2015 9:20 pm

Re: Extremely severe slowdown in http://asa.org.il/

Post by Safwat »

In my opinion, this is more serious than a filter error. I think Adblock plus should have a sort of failsafe mechanism which detects a misbehaving filter and does something about it. The most naive implementation would be stopping when a filter is catched, say, ten thousand times. But I'm sure better failsafe mechanisms are out there.
Safwat
Posts: 3
Joined: Sat Oct 17, 2015 9:20 pm

Re: Extremely severe slowdown in http://asa.org.il/

Post by Safwat »

My SSD was writing 10MB/s of data per second for about 5 minutes before I detected the issue, that's 3 GBs. Someone else might have encountered this, but was less tech-savvy to notice it, Adblockplus might have already written Terabytes on someone's drive. Surely a mere filter error should not have the technical capability to cause such mayhem, and a layer of protection should be in place. It could be as simple as "Stop this filter if it's detected 1 thousand times", or something more complicated.

By the way, what's written to the drive, exactly? I assumed it's updating the stat counter as frequently as the hard drive can write. Is that the case?
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: Extremely severe slowdown in http://asa.org.il/

Post by mapx »

in firefox: if (see options) "count filter hits" is enabled ABP will rewrite patterns.ini (to add the new count to the various filters)
so, you can test disabling that option but anyway it's some loop in that case.

the filter above worked for you ? periodically there are sites / pages with this type of issue.
anyway, you can report an issue on the bug tracker, asking for further investigation / improvement
https://issues.adblockplus.org
Locked