vk.com - element hiding precedence bug(?)

Posting here is no longer possible, please use the forum of a filter list project, such as EasyList
Locked
djibouti
Posts: 16
Joined: Sat Jul 25, 2015 3:13 am

vk.com - element hiding precedence bug(?)

Post by djibouti »

Hello guys, here's the situation:

On https://vk.com, you can view your updates:
Мои новости --> Обновления (Russian) or
My News --> Updates (English)

The list of updates includes notifications about your friends' joining new groups.
The HTML code for the short descriptions of the groups (including the group logo and a link to it) in the notifications is as follows:

Code: Select all

<div class="group_share clear clear_fix">
...
</div>
I'm subscribed to Fanboy's Annoyance List, and it has an element hiding rule, specifically, ##.group_share, so the <div> above gets hidden.
I made an exception for vk.com: vk.com#@#.group_share, and it worked okay.

but:
vk.com#@#div.group_share doesn't work (##.group_share is in effect),
vk.com#@#[class="group_share"] doesn't work either (the same)
vk.com#@#.group_share.clear.clear_fix doesn't work (the same)
vk.com#@#[class="group_share clear clear_fix"] doesn't work (the same).

What's wrong? (if anything is)


Browser: Firefox v. 36.0.4
AdBlockPlus: v. 2.6.9.1.
Last edited by djibouti on Sat Jul 25, 2015 5:35 am, edited 1 time in total.
User avatar
fanboy
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am
Contact:

Re: vk.com - element hiding precedence bug(?)

Post by fanboy »

After the whitelist is added, does it show other social/annoyances elements being loaded?
djibouti
Posts: 16
Joined: Sat Jul 25, 2015 3:13 am

Re: vk.com - element hiding precedence bug(?)

Post by djibouti »

After the whitelist is added, does it show other social/annoyances elements being loaded?
You mean, can other element hiding rules be seen in the blockable itmes list after I add my exception rule? If so, yes, they can.
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: vk.com - element hiding precedence bug(?)

Post by mapx »

after adding the exceptions above:
submit an issue report, then post here the report's link
djibouti
Posts: 16
Joined: Sat Jul 25, 2015 3:13 am

Re: vk.com - element hiding precedence bug(?)

Post by djibouti »

Here's the report: https://reports.adblockplus.org/0fe5804 ... aea8da6195
(I followed the "Known issues" link from the report, there wasn't any info there that would help).
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: vk.com - element hiding precedence bug(?)

Post by mapx »

I can reproduce the "issue" or ...issue, I dont know if it's wanted or other (using some other site)

for example:
if I have this filter:
##DIV#tweetsharebtn

I can whitelist it only using:
#@#DIV#tweetsharebtn

but not
#@#div#tweetsharebtn
or
#@##tweetsharebtn

I wrote to a developer, asking if it's a bug or a wanted behaviour, we'll see ...
User avatar
fanboy
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am
Contact:

Re: vk.com - element hiding precedence bug(?)

Post by fanboy »

If someone can give me the suggested element whiltelists, I'll add them to the Social list.
djibouti
Posts: 16
Joined: Sat Jul 25, 2015 3:13 am

Re: vk.com - element hiding precedence bug(?)

Post by djibouti »

Thank you, mapx.

fanboy, I think the more specific the rule is, the better, but since the only one (so far?) that overrides ##.group_share on vk.com seems to be vk.com#@#.group_share, I'd suggest adding it.
Last edited by djibouti on Sun Jul 26, 2015 3:19 am, edited 1 time in total.
User avatar
fanboy
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am
Contact:

Re: vk.com - element hiding precedence bug(?)

Post by fanboy »

So this fixes the issue?

Code: Select all

vk.com#@#.group_share
djibouti
Posts: 16
Joined: Sat Jul 25, 2015 3:13 am

Re: vk.com - element hiding precedence bug(?)

Post by djibouti »

So this fixes the issue?
It does, I wrote about it in my first post :)

But actually the question/issue was why none of the following four

vk.com#@#div.group_share
vk.com#@#[class="group_share"]
vk.com#@#.group_share.clear.clear_fix
vk.com#@#[class="group_share clear clear_fix"]

do the same? (override ##.group_share).


Well, mapx said "we'll see". So we'll see.
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: vk.com - element hiding precedence bug(?)

Post by mapx »

yes, I can confirm, the exception rule is applied to the same selectors as in the original hiding rule. It's how is implemented.
so, if the official list contains
##.group_share

the only exception that will work (for a domain) is:
example.com#@#.group_share
Element hiding exceptions, merely prevent filters with an identical selector from being applied, rather than unblocking matching elements
Locked