Page 1 of 1

[Done] Indication if subscription contains disabled filters

Posted: Mon Jan 04, 2010 11:26 pm
by Hubird
In the following thread

forum/viewtopic.php?f=4&t=2654

I put forward an idea to Indicate that some filters in a subscription are disabled, you liked the idea but said efficient implementation would be problematic.

I was just wondering if this was going to happen, problematic isn't impossible and I still feel it would be useful.

Re: Indication if subscription contains disabled filters

Posted: Tue Jan 05, 2010 9:02 am
by Wladimir Palant
Ok, let's discuss this again - moved to future development forum.

This suggestion would mean that the preferences window needs to keep the count of disabled filters for each subscription (recalculating it every time it is needed is certainly not an option). This count needs to be updated when filters are disabled/enabled, moved or deleted, when subscriptions are updated, probably in more situations. Making sure that it is correct under all circumstances sounds like a tricky affair, will certainly add some complexity to the already overly complicated code.

Conclusion: At the moment I cannot see the big gain that would justify this. But I will be happy to learn otherwise.

Re: Indication if subscription contains disabled filters

Posted: Mon Jan 11, 2010 3:30 pm
by Erunno
I guess it's mostly useful for subscription list maintainers and less so for ordinary users who subscribe to a list and leave it at that. I frequently have to disable certain filters either to test out new ones or in order to fix bugs and sometimes I forget to deactivate them after I have finished whatever prompted me to disable a filter in the first place. A visual cue in the subscription list window would surely help with the obsessive-compulsive disorder to check the filter lists regularly for inactive filters, especially when one is not using the activation sorting order and collapses the lists by default. It would just be a convenience but if the implementation costs are really that high I can live without (as I have until now).

Re: Indication if subscription contains disabled filters

Posted: Tue Nov 02, 2010 7:09 am
by Hubird
Wouldn't it be enough to just update the the count when the preference windows was first opened and when the apply button was pressed ?

Re: Indication if subscription contains disabled filters

Posted: Tue Nov 02, 2010 11:38 am
by Wladimir Palant
No, users will complain then that this indicator is "stuck". Anyway, I want to consider this proposal again when redesigning preferences dialog for Adblock Plus 1.4.

Re: [Done] Indication if subscription contains disabled filters

Posted: Sat Jun 23, 2012 8:29 am
by Wladimir Palant
I forgot to update this thread. This feature was implemented in Adblock Plus 2.0.