Blocks my 'Add To Kaboodle' button

Posting here is no longer possible, please use the forum of a filter list project, such as EasyList
Locked
keiron

Blocks my 'Add To Kaboodle' button

Post by keiron »

I'm one of the co-founders at Kaboodle (www.kaboodle.com) and we've had some of our users report that Adblock Plus stops their 'Add To Kaboodle' button from working.

We use a javscript bookmarklet to insert JS into the current webpage so users can save it to their kaboodle lists. From playing with Adblock it looks like it's blocking our inserted JS from loading.

I added the following filter to Adblock:
@@|http://www.kaboodle.com/

Which seems to allow kaboodle to do it's thing. I wanted to check this was the correct thing to recommend to our users and also see if there is somewhere we can post this for all Adblock users since our JS is only ever run as a result of a user clicking our 'Add To Kaboodle' button explicitly.

Thanks for the help

- Keiron
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Re: Blocks my 'Add To Kaboodle' button

Post by rick752 »

keiron wrote:I'm one of the co-founders at Kaboodle (www.kaboodle.com) and we've had some of our users report that Adblock Plus stops their 'Add To Kaboodle' button from working.

We use a javscript bookmarklet to insert JS into the current webpage so users can save it to their kaboodle lists. From playing with Adblock it looks like it's blocking our inserted JS from loading.

I added the following filter to Adblock:
@@|http://www.kaboodle.com/

Which seems to allow kaboodle to do it's thing. I wanted to check this was the correct thing to recommend to our users and also see if there is somewhere we can post this for all Adblock users since our JS is only ever run as a result of a user clicking our 'Add To Kaboodle' button explicitly.

Thanks for the help

- Keiron
If it is whitelisting, then what filter string is actually blocking it? Also what subscription(s) are you using?
Wladimir Palant

Post by Wladimir Palant »

It should be easier to fix the problem ;)

From what I can see that's the script that is blocked:

http://www.kaboodle.com/ht/scripts/add/ ... r0_24_0_45

Looking at the popular filter subscriptions, it matches the filter /banner*?$~subdocument in EasyList, /banner. in dutchblock and some awfully long regexp in Filterset.G. With a name like this, false positives really should be expected - maybe you can rename this script into something less ambiguous? As far as I can see it doesn't really have anything to do with banners, it simply adds a "Loading..." block (or "Adding to Kaboodle..." in this case).
User avatar
rick752
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA
Contact:

Post by rick752 »

Wladimir Palant wrote: Looking at the popular filter subscriptions, it matches the filter /banner*?$~subdocument in EasyList, /banner. in dutchblock and some awfully long regexp in Filterset.G.
EasyList: removed string.
Logged, fixed and uploaded. :arrow:
keiron

Re: Blocks my 'Add To Kaboodle' button

Post by keiron »

rick752 wrote: If it is whitelisting, then what filter string is actually blocking it? Also what subscription(s) are you using?
I'm using EasyList (USA), not sure what our users have been using.
keiron

Post by keiron »

rick752 wrote: EasyList: removed string.
Logged, fixed and uploaded. :arrow:
Wow, that's great thanks. I'll also see to change the banner.js file name to avoid similar conflicts in the future...didn't think about the implications of calling it that :D
Locked