Potential issues with Adversity Antisocial?

Posting here is no longer possible, please use the forum of a filter list project, such as EasyList
Locked
auserofabp

Potential issues with Adversity Antisocial?

Post by auserofabp »

I was looking at the hit counts on the filters for Adversity Antisocial when I noticed the following potential issues:

Code: Select all

/addthis.domain=~skycomp.com.au
Should be?

Code: Select all

/addthis.$domain=~skycomp.com.au
I was also wondering if

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com
might be better as

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com|~webcache.googleusercontent.com
Unless Google's cache relies on loading content from -opensocial.googleusercontent.com domains?
Marijo
Posts: 90
Joined: Wed Jun 29, 2011 4:37 pm

Re: Potential issues with Adversity Antisocial?

Post by Marijo »

auserofabp wrote:Should be?

Code: Select all

/addthis.$domain=~skycomp.com.au
Fixed.
auserofabp wrote:I was also wondering if

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com
might be better as

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com|~webcache.googleusercontent.com
Unless Google's cache relies on loading content from -opensocial.googleusercontent.com domains?
I'll inform Hubird about this as I don't have an example where this whitelist is triggered.
auserofabp

Re: Potential issues with Adversity Antisocial?

Post by auserofabp »

Marijo wrote:
auserofabp wrote:I was also wondering if

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com
might be better as

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com|~webcache.googleusercontent.com
Unless Google's cache relies on loading content from -opensocial.googleusercontent.com domains?
I'll inform Hubird about this as I don't have an example where this whitelist is triggered.
Bear in mind that I wrote that rule not knowing the initial purpose of the whitelist. I had assumed it was to avoid breaking Google Docs (has happened to me before without a whitelist like this). My main concern here is that whitelisting anything on entire of googleusercontent.com is effectiely whitelisting it on the entire Internet for anyone who uses Google's webcache.
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

Re: Potential issues with Adversity Antisocial?

Post by Hubird »

Rule was added for

http://www.google.com.au/ig

When I initially added the rule I made a not in the Antisocial list saying the filter should be removed if it gets hits anywhere other than on Google services.

The rule is less than ideal and if someone can come up with a better rule I'm open to suggestions :)
auserofabp

Re: Potential issues with Adversity Antisocial?

Post by auserofabp »

Knowing the purpose of the whitelist, I would like to suggest replacing

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com
with the rule I wrote in the original post:

Code: Select all

@@-opensocial.googleusercontent.com^$domain=googleusercontent.com|~webcache.googleusercontent.com
Going to http://www.google.com/ig?hl=en with the exception rule enabled, I did not find "webcache.googleusercontent.com" in the blockable items list, so I don't think this rule switch would cause any issues on that page?
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

Re: Potential issues with Adversity Antisocial?

Post by Hubird »

Have you got an example where I can see

webcache.googleusercontent.com

in action?

Also I will make the whitelist apply to scripts and xmlhttprequest only because as it is now it also whitelists

Code: Select all

http://www.google-analytics.com/__utm.gif?
On http://www.google.co.uk/ig
auserofabp

Re: Potential issues with Adversity Antisocial?

Post by auserofabp »

I don't have an example off the top of my head but here is how to get one: Find a site that is not google that loads something from a -opensocial.googleusercontent.com domain, then go to that website through Google's cache. I am guessing that you might know some examples of such sites given the blocking filter for -opensocial.googleusercontent.com on non-Google domains?
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

Re: Potential issues with Adversity Antisocial?

Post by Hubird »

Changed to

Code: Select all

@@-opensocial.googleusercontent.com^$xmlhttprequest,script,domain=googleusercontent.com|~webcache.googleusercontent.com
https://code.google.com/p/adversity/sou ... f0c4bc5027

https://code.google.com/p/adversity/sou ... 7be1cb6b6f
auserofabp

Re: Potential issues with Adversity Antisocial?

Post by auserofabp »

Thanks Hubird and Marijo.
User avatar
Hubird
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia
Contact:

Re: Potential issues with Adversity Antisocial?

Post by Hubird »

No problem, thanks for helping improve Antisocial.
Locked