Page 1 of 1

Bug of element hiding rules

Posted: Wed Apr 11, 2012 12:07 pm
by knight00931
I am using ABP dev build 2.0.4b.3043 with Firefox Nightly 20120410 on Win7 Enterprise x64 sp1.

Steps to reproduce:

1. Go en/
2. Add ##body ,page content is hided.
3. Add ~adblockplus.org##body then refresh. Page content isn't hided now (but it shoud be).
4. disable ##body , then enable it.
5. Refresh the Page. Content is hided again.
6. disable ~adblockplus.org##body , then enable it.
7. Refresh the Page. Page content isn't hided now, but it shoud be.

I believe ##body should hide everything even there is another filter like ~adblockplus.org##body.
So could you fix it?Thanks.

Re: bug of element hiding rules

Posted: Wed Apr 11, 2012 2:14 pm
by Lain_13
I actually would like to have opposite thing like hide merging functionality.

So if we have 3 rules:
#body
~adblockplus.org,~another.site##body
~something.else,~another.site##body
they will be represented as ~adblockplus.org,~another.site,~something.else##body
This function must not merge '~domain' and 'domain' rules! So if we have rule domain.name##body then it must not be merged with exceptions.

Such functionality will allow to make exceptions for hiding rules from main subscription in regional subscriptions without necessity to modify main subscription.

Re: Bug of element hiding rules

Posted: Mon Apr 16, 2012 9:34 pm
by dindog
I agree with Lain_13. In fact, I even make a feature request about whitelist existing rule...( I even come up with a not so well implement.)
forum/viewtopic.php?f=11&t=9660

why would you want that? It would helpful for us, making Easylist false positive rule ( in non-English regions ) inactivate accurately instead of putting a universal whitelist like $elemhide.

Re: Bug of element hiding rules

Posted: Mon Apr 16, 2012 9:40 pm
by knight00931
I am now talking about a BUG, the same filters but different behavior.
If you have any suggestions, just use another topic, OK?

Re: Bug of element hiding rules

Posted: Mon Apr 16, 2012 9:51 pm
by dindog
err.. it probably relates to the recent change that make pattern.ini async