[Fixed] Some resources do not appear in blockable items

Posting here is no longer possible, please use the corresponding product forum.
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

[Fixed] Some resources do not appear in blockable items

Post by MonztA »

1. Open https://adblockplus.org/.
2. Open the list of blockable items.
3. The frame of the Youtube video is not listed there.

This bug causes issues with blocking elements via right-click: forum/viewtopic.php?f=11&t=11654

ABP 2.2.2a.3594 with FF 17. It does not seem to be reproducible always (clearing cache and restarting FF may be needed).

I thought it was a recent issue because I encountered this on many sites just couple of days ago (it also happens for some scripts). So I tried to track down the exact ABP version where this bug was introduced but it happens also in 2.1+.
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: Some resources do not appear in the list of blockable items

Post by MonztA »

Maybe a better example: http://seclists.org/bugtraq/2005/Jan/195

Sometimes it looks like this: http://i.imgur.com/T2esL.png (open the list of blockable elements after page finishes loading)
If I reload it, there is much more: http://i.imgur.com/W8Nev.png

Unfortunately, I have no idea how to reproduce it.
Lex1

Re: Some resources do not appear in the list of blockable items

Post by Lex1 »

Another example: forum/viewtopic.php?f=11&t=11740
Btw, this bug not present on old, non restartless, abp 2.0.3.
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: Some resources do not appear in the list of blockable items

Post by MonztA »

I also noticed the flash object is not listed here (press play, then open the list of blockable elements).
jack.mauro
Posts: 10
Joined: Thu Dec 06, 2012 9:39 am

Re: Some resources do not appear in the list of blockable items

Post by jack.mauro »

This seems to be random, but if you refresh the page (F5? Ctrl+F5?) with the panel already open, usually everything appears....
auserofabp

Re: Some resources do not appear in the list of blockable items

Post by auserofabp »

A few things that might help the developers resolve this bug:

- Does this occur in versions of Firefox other than 17.x, and if so, which ones?
- Are there any common attributes to the items that don't always appear as blockable items, or does it seem completely random? Look at html code and any relevant JS/CSS. The Firefox Page Inspector might be good for this.
- Is it always the same items that don't show up as blockable on the webpages where this issue occurs, when it occurs?
- Could this be a conflict with another extension?
- Does downgrading from a newer ABP to old ABP 2.0.3 resolve the issue (regardless of Firefox version), or does the issue persist?

Also, no one with this issue has posted their OS, which Wladimir has requested on the website where he gives instructions on how to file a bug report.
User avatar
Crits
Posts: 394
Joined: Mon Jan 16, 2012 11:54 am
Location: France
Contact:

Re: Some resources do not appear in the list of blockable items

Post by Crits »

I sincerely hope the bug will be taken into consideration, as it makes filter list maintenance more tedious.

It also impacts user reports, making it more difficult to solve some cases of false-positives (or false-negatives) when the issue is not easily reproducible.
Example report: https://reports.adblockplus.org/370ff94 ... 9432d3ab10
||clients1.google.com^ appears in the FIlter tab but does not match any request in the Requests tab

Mozilla Firefox 17.0.1, Gecko 17.0.1 build 20121128204232
Adblock Plus: 2.2.2a.3606
Windows 8 x64
Author of Liste FR, an ad-blocking subscription for French websites
Anonymous「

Re: Some resources do not appear in the list of blockable items

Post by Anonymous「 »

I've found this one: https://reports.adblockplus.org/ef9a807 ... 55#tab=all

Page is http://www.sankakucomplex.com/2013/01/0 ... oka-style/, ad <iframe> not appearing in the list of blockable elements is http://yoko.otaserve.net/a.de/?&id=7089&z=26&r=3&si=DVD&bn=542224&s=salesrank&iw=140&n=5&type=horizontal-2&min=1&max=1&ht=Top%20Products&opt=on&mimp=5000.

Bonus information: I'm on Windows XP and this issue seems to affect all articles on sankakucomplex.
Celestia

Re: Some resources do not appear in the list of blockable items

Post by Celestia »

I'm getting the same behavior on 18.0. The problem is appearing on a fairly wide array of websites, usually ones with a higher than average number of images and elements.
auserofabp

Re: Some resources do not appear in the list of blockable items

Post by auserofabp »

Lex1 wrote:this bug not present on old, non restartless, abp 2.0.3
No. It IS present on ABP 2.0.3. It's just less bad (and probably also less prevalent, haven't done much testing yet). With a test duplicate of my profile (replacing Adblock Edge with ABP 2.0.3 and applying my settings) I reproduced it on http://tunein.com/radio/DI-Deep-House-s171231/. The blockable items window listed 9 blocked items but ABP (correctly) counts 10. The filter where request didn't get listed in blockable items window is ://ads. from EasyList.

Also, reloading the page temporarily fixed the bug but simply closing and re-opening the blockable items window in ABP 2.0.3 reproduced the bug again in exactly the same way. During time of close and re-open, another item got blocked by ABP.

Firefox 18.0
Mac OS X 10.7.4

@ABP developers: based on this and anything else you know, feel free to edit my previous post to better target my questions to info you need.
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: Some resources do not appear in the list of blockable items

Post by MonztA »

According to Wladimir this bug is responsible for it. Unfortunately, there is no work-around for it at the moment.
Wladimir Palant

Re: Some resources do not appear in the list of blockable items

Post by Wladimir Palant »

I just committed a workaround - we are now using the deprecated approach that we only used in old Firefox versions before, couldn't find any better solution. There will be a new development build in 5 minutes, it should work. If no issues pop up we can have a minor Adblock Plus release next Tuesday.
Lex1

Re: [Fixed] Some resources do not appear in blockable items

Post by Lex1 »

There will be a new development build
Works for me. Thanks Wladimir.
auserofabp

Re: [(not)Fixed] Some resources do not appear in blockable items

Post by auserofabp »

Unfortunately the latest Adblock Plus release has not completely fixed this bug. Some resources aren't even detected by ABP (not counted in blocked items count or listed as blocked in Blockable Items window), and as for the ones that are detected, the issue description is the same as the one I reported for ABP 2.0.3 in Firefox 18.0 in my previous post. The example website would also be the same. This occurred using Firefox 18.0.2 and a test profile with the latest AMO version of Adblock Plus.
Locked