Page 1 of 2

[Invalid] ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 5:11 pm
by df
If "url-addon-bar" add-on is enabled, no ABP-button appears. It happens since ABP is restartless

Is it a ABP or url-addon-bar bug?

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 9:28 pm
by Wladimir Palant
I don't see this issue - everything seems to work fine even if url-addon-bar is installed. What happens if you go into Adblock Plus options and check "Show in add-on bar"?

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 9:45 pm
by df
After installing it works, but after restarting Firefox not. After restart i can't activate "Show in add-on bar".

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 11:06 pm
by Wladimir Palant
Nope, I explicitly tested restart as well - still works for me after a restart (Firefox 13 and Firefox 16.0a1).

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 11:08 pm
by Rayge
My Adblock Plus Button also disappeared since int's restartless. I always had it next to the URL Bar. The Button also does not appear under "customize" anymore so I can't put it back.

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 11:09 pm
by Wladimir Palant
@Rayge: Open Add-ons Manager, select Adblock Plus, click Options button and then check "Show in add-on bar" - does that work? If not: please create a new topic, mixing up unrelated issues in one topic makes things harder for me to investigate and fix.

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 11:11 pm
by Rayge
Yes, I can get it to show up in Addon Bar, but not at the top next to the URL Bar, since it does not appear under "customize" anymore. I use the latest Aurora. and the latest Adblock Plus Developer Version.

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 11:12 pm
by Wladimir Palant
Rayge, just drag it to the other toolbar while the Customize window is open...

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Wed Jun 20, 2012 11:19 pm
by Rayge
Thank you, that worked =)

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Thu Jun 21, 2012 12:07 am
by df
i figured it out, it's a combination of url-addon-bar and Toolbar Appmenu Button. If both add-on are enabled, the button doesn't appears.

Re: ABP 2.1b + url-addon-bar = no ABP button

Posted: Thu Jun 21, 2012 3:45 pm
by Wladimir Palant
That makes more sense. I'm not sure how but Toolbar Appmenu Button (particularly its "Shring Titlebar" feature) breaks the relationship between the toolbar and its toolbox - toolbar.toolbox property is simply null. Consequently, Adblock Plus ignores it as an invalid toolbar (adding buttons to it isn't possible). I would recommend notifying Toolbar Appmenu Button author about this issue. Also, I would recommend staying away from the "Shring Titlebar" feature - it uses mutation events meaning that it slows down the browser considerably.

Marking as Invalid since that's clearly not our bug.

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Posted: Thu Jun 21, 2012 3:57 pm
by df
Without this feature ABP button appears.
Image

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Posted: Mon Jul 09, 2012 4:27 pm
by Wladimir Palant
Turned out that I was wrong and the bug is actually in url-addon-bar. I notified the author that he shouldn't be removing the toolboxid attribute from the add-on bar, this is actually what's causing the issues.

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Posted: Sat Feb 23, 2013 9:01 am
by guest
test

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Posted: Sat Feb 23, 2013 9:09 am
by guest
Sorry for the test message above.

I just wanted to add my very similar experience w/ FireFox 19. I lost the icon completely, not even available anywhere even when in Customize mode. The option to check "show in addonbar" could not be selected. My solution was to Disable every addon except AdBlock Plus, restart Firefox, then finally I could check the "show in addonbar", and it would appear where
it always has been.

Unbelievably while typing this comment - the AdBlock Plus icon just disappeared - even after it had been working for over
an hour. I guess I will do the above steps again to get it back. It seems something is "overwriting" its ID if i had to guess.

<sigh>