Page 1 of 1

Removing Filter Subscription Confirmation Title

Posted: Tue Feb 02, 2010 9:46 pm
by Michael
When removing a filter subscription from the Adblock Plus preferences the question window that then appears to confirm whether the user wants to remove the subscription has a title of [JavaScript Application]. Is the issue that the string that should act as the title has not yet been translated?

Re: Removing Filter Subscription Confirmation Title

Posted: Tue Feb 02, 2010 9:54 pm
by Wladimir Palant
No, I was simply too lazy to use a proper dialog - that's the confirmation dialog web pages use.

Re: Removing Filter Subscription Confirmation Title

Posted: Tue Feb 02, 2010 10:01 pm
by Wladimir Palant
Fortunately, the code to fix this is already there, so here we go: https://hg.adblockplus.org/adblockplus/rev/8fd8138586f6

The title will be "Adblock Plus" - it might be changed to something more proper when I stop being lazy.