[BUG] Element rule works eventhough site is whitelisted

[dennis]

Hi

I have a site in "My exception rules" (@@http://www.website.tld/) and when I load the page, that rule gets many hits. So that seems to work.

I also have a "My element hiding rules" rule that looks like this;
#div(id*=banner)

The thing is that the banner (top image) on that site disappears. If I deactivate the element rule it works again.

Shouldn't the element hiding rule be disabled too when the site is added as an exception?

[Ares2]

Shouldn't the element hiding rule be disabled too when the site is added as an exception?

Yes, normally it should. Can you give us a real example?

[dennis]

Shouldn't the element hiding rule be disabled too when the site is added as an exception?

Yes, normally it should. Can you give us a real example?

I don't know if you can see the site, but the site is;

http://www.swebits.org/

Rules;

@@http://www.swebits.org/
#div(id*=banner)

[Ares2]

OK, Bug confirmed (although I have to use @@http://swebits.org/ - without the www - probably because I'm not logged in).

[rick752]

I can't see it but I will guess why.

You said that you see "http://www.website.tld" hit many times in the blockable items list. If the site was truly whitelisted, you wouldn't see that. It would just say "whitelist page" on one line in the "blockable items" list.

Are you sure that is the EXACT domain name of the page you are on (is it using "//www."?). Are you using today's release of Adblock Plus?

Try this instead and see:

Code: Select all

@@http://*website.tld

This will allow any version of that domain ... and subdomains too.

[dennis]

OK, Bug confirmed (although I have to use @@http://swebits.org/ - without the www - probably because I'm not logged in).

Sorry. That's the rule. My bad.

[rick752]

Oops ... looks like Ares beat me too it.

[Wladimir Palant]

Ok, I see what happened there - it isn't hidden but the CSS property "display:inline" is applied anyway. That one is only needed for Firefox 2 compatibility, so as an easy solution I can apply that CSS property in Firefox 2 only - then we have less of a problem.

[Wladimir Palant]

Done that: http://hg.mozdev.org/adblockplus/rev/fa94757737b5

So now we only have this issue in Firefox 2. With Firefox 2 support period running out very soon I am not sure whether this is worth spending more time on.

[dennis]

Done that: http://hg.mozdev.org/adblockplus/rev/fa94757737b5

I'm really impressed how fast you solved this bug. Just 12 hours from my initial post.

Thank you. Great work.

[kingrat]

This fixes a problem with my site as well.