context menus slow with Adblock Plus 0.7.0.1

Fox · Post by **Fox** » Mon May 22, 2006 9:47 pm

Master X wrote:And perhaps that is the reason, why it is getting so slow, when adblock plus always trys to check the list, when the context menu is called...

This is the thing i did wanna ask before, did that slow down happen every time context menu was opened, or only when used over images.

ps: i did little forget how it really works when i did make this post and before that

ecjs · Post by **ecjs** » Tue May 23, 2006 6:21 pm

Master X wrote:it is getting so slow, when adblock plus always trys to check the list, when the context menu is called.

A static solution would be cleaner in my opinion.

You are obviously right. The slowdown must be due to the fact ADP performs the check each time the context menu is called.

Peng · Post by **Peng** » Thu May 25, 2006 6:59 am

But the check shouldn't take any noticeable amount of time, and doesn't for many of us, anyway.

(Note to self: Check in different versions of Firefox.)

XerBlade · Post by **XerBlade** » Fri May 26, 2006 5:50 am

Regardless, causing large CPU spikes with just standard context menu calls is obviously bad, always noticeable (through casual use, not watching processor usage) or not. Bringing up the context menu isn't supposed to be a difficult process.

P.S. I went ahead and multi-version tested, and, though I'm getting spikes from 0 (at normal Firefox usage) to somewhere in the 20s or 30s (on context menu call) in Firefox 1.5.0.3, it's still acting normal in Bon Echo and Minefield. I don't have a 1.0.x version installed to test, but I suspect it probably works about the same as 1.5 in that area. I don't appear to be getting them in Flock 0.5.15.0 either.

Peng · Post by **Peng** » Fri May 26, 2006 7:18 am

XerBlade wrote:Regardless, causing large CPU spikes with just standard context menu calls is obviously bad, always noticeable (through casual use, not watching processor usage) or not. Bringing up the context menu isn't supposed to be a difficult process.

P.S. I went ahead and multi-version tested, and, though I'm getting spikes from 0 (at normal Firefox usage) to somewhere in the 20s or 30s (on context menu call) in Firefox 1.5.0.3, it's still acting normal in Bon Echo and Minefield. I don't have a 1.0.x version installed to test, but I suspect it probably works about the same as 1.5 in that area. I don't appear to be getting them in Flock 0.5.15.0 either.

Post 6666! Whoo!

XerBlade · Post by **XerBlade** » Sat May 27, 2006 7:00 am

Peng wrote:
XerBlade wrote:Regardless, causing large CPU spikes with just standard context menu calls is obviously bad, always noticeable (through casual use, not watching processor usage) or not. Bringing up the context menu isn't supposed to be a difficult process.

P.S. I went ahead and multi-version tested, and, though I'm getting spikes from 0 (at normal Firefox usage) to somewhere in the 20s or 30s (on context menu call) in Firefox 1.5.0.3, it's still acting normal in Bon Echo and Minefield. I don't have a 1.0.x version installed to test, but I suspect it probably works about the same as 1.5 in that area. I don't appear to be getting them in Flock 0.5.15.0 either.
Post 6666! Whoo!

Really? I hadn't even noticed, and probably wouldn't have had you not said anything. Interesting.

Wladimir Palant · Post by **Wladimir Palant** » Sat Jun 03, 2006 5:07 pm

@Master, @sremick: Sorry, I forgot that the permission manager deals with cookies and popups as well, not just images. And unfortunately you can't request only one type being listed. Do you have many entries in the cookies or popups exception list?

Master · Post by **Master** » Sun Jun 04, 2006 2:33 am

I don't want to count manually but at a quick glance I would say I have several hundreds cookies in the exception list. It takes several seconds to firefox to display the list.
I think we have found the problem

Wladimir Palant · Post by **Wladimir Palant** » Sun Jun 04, 2006 11:42 am

Yes, that's it... So I should probably not check the permission manager every time but rather check it once and save the result.

sremick · Post by **sremick** » Mon Jun 05, 2006 7:11 pm

Yes, my cookies list is huge. I do not block all or allow all, but have it prompt me per-site. Over time my list has grown considerably.

Wladimir Palant · Post by **Wladimir Palant** » Tue Jun 06, 2006 2:38 pm

@Master: I had to add 5000 cookie entries to reproduce the delay you are describing

I changed it, now permission manager is checked only once. Consequence is that a change of extensions.adblockplus.hideimagemanager requires browser restart. Development build coming shortly...

Master · Post by **Master** » Sun Jun 11, 2006 9:37 pm

Just to say that 0.7.0.2 correctly fixes the problem.